feat: Implemented ReCaptcha Verification in sign_up process #2446
Conversation
|
Why did you create a pr for an issue that has already been claimed by someone else, who has already made a pr? |
My apologies, Sorry! |
|
As the above pull request makes the changes that were asked to make in the #2360 and to satisfy which, another #2444 was opened and neither of which includes the requested changes like ReCaptcha_Key storage issue and the build issue(e.g. the build fails in both of the previous MRs when key is not supplied) and the issue related to usage of timber, so REOPENING it. |
|
@liveHarshit please review |
app/src/main/java/org/fossasia/susi/ai/signup/SignUpActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/susi/ai/signup/SignUpPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/susi/ai/signup/SignUpActivity.kt
Outdated
Show resolved
Hide resolved
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of db2b51f. Here's the output:
|
|
@s-ayush2903 status ? |
|
@s-ayush2903 are you still working on this? |
4 participants
Fixes #2350
Changes: Some dependencies required for ReCaptcha implementation were added, and corresponding changes were made accordingly.
I am with this embedding two screenRecordings that display the proposed changes.
(This represents the state of the app when the key is present)
(And This represents the state of the app when the key is not present)
